Skip to content

e2e: add open-graph image tests #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2025
Merged

e2e: add open-graph image tests #692

merged 4 commits into from
Jan 8, 2025
+171 −0

Conversation

@sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Jan 5, 2025 •
edited
Loading

This PR will add e2e testing for next/og and opengraph-image.tsx in the app router

  • An empty page on the route /og that should have an opengraph image present in the metatags.
  • An API route on /api/og that returns an ImageResponse from next/og.

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8657126

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vicb
vicb reviewed Jan 7, 2025
View reviewed changes
@sommeeeer
Copy link
Contributor Author

sommeeeer commented Jan 7, 2025 •
edited
Loading

Perhaps we should consider adding another test for checking when something custom is passed to options in ImageResponse it will be used in the HTTP response?

docs: ImageResponse

conico974
conico974 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit 8530f7c into opennextjs:main Jan 8, 2025
1 check passed
@sommeeeer sommeeeer deleted the e2e-og-image branch January 8, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb left review comments

@conico974 conico974 conico974 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sommeeeer @vicb @conico974